Add required '--add-opens' to cli script #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is fine, I'll port to branch 2.5.x. |
|
Thank you! When porting this to v2.5.x, wouldn't the script fail when running with Java 8? |
I'll test, in that case we can document it at least. We'd had a couple of questions about it in the maven plugin and at least that way we have an official statement and explanation. |
|
Will you pull this into the v2.5.x or is there a schedule for v3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Remove
WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystemmessage at least when running the CLI.How does it achieve that?
Simply adds required
--add-openoptions.Are there any alternative ways to implement this?
No.
Are there any implications of this pull request? Anything a user must know?
This is not related to #1034, and does not fix it.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1155
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc