-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try lifting to Gradle 7.0 #1001
Conversation
Worked fine for me on Linux and MacOS. Thanks!! |
Thanks! And the CI build also worked with Java 16 now. |
I'll check the poms tomorrow if they are still correct. |
Running locally I see |
I managed to fix the Wildfly integration test. Also upgraded Gradle to 7.0-rc-1. The generated poms are mostly identical now to the previous version, only the dependency for jcommander has changed from compile to runtime. I think this is fine since this library is only used for the CLI. |
Stupid me, I was running with a wrong Java version, Wildfly still fails on Java 16. |
I got it working on my Linux machine.
Furthermore, this runs without adding any extra Java16 condition to the build scripts. |
Great find! |
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
This PR tries to bring the build to Gradle 7.0.
I can't tell if the dependency declarations are all correct, the new scopes are still a mystery right now (I didn't spend much time yet digging into them)
Except the wildfly integration test everything seems to run on OSX.
@abelsromero Could you please check if this works on your machine? I've seen your issue yesterday and made an attempt myself today.
How does it achieve that?
Are there any alternative ways to implement this?
Are there any implications of this pull request? Anything a user must know?
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc