Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI build for Java 9 #591

Closed
robertpanzer opened this issue Nov 18, 2017 · 6 comments
Closed

Add CI build for Java 9 #591

robertpanzer opened this issue Nov 18, 2017 · 6 comments

Comments

@robertpanzer
Copy link
Member

robertpanzer commented Nov 18, 2017

It looks like JRuby (>=9.1.14.0) and AsciidoctorJ are ready to run on Java 9 (>=9.0.1).
The CI build on Travis should also run the build on Java 9.

It looks like the version of Gradle that we use at the moment, 2.14.1, doesn't run on Java 9.
Therefore I guess the hardest part of this task is to upgrade the build to a current version of Gradle.

It would be also nice to see if it's already time to migrate the build to Kotlin or if Groovy is still the way to go. (Is Gradle called Kradle then? 😉 )

@mojavelinux
Copy link
Member

Yeah for Java 9 support in JRuby! Too bad about Gradle, though.

I wonder if it would be possible to fork the tests so that the version of Java we use for tests doesn't affect the version we use to run Gradle.

I support the effort to explore Kradle as another route.

tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 8, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
related to asciidoctor#591
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 8, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 9, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 9, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 9, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 9, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 10, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 10, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 10, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 10, 2018
* updated groovy to a java 9 compatible version
* fixed classpath issues in tests

Closes asciidoctor#591
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 10, 2018
* updated groovy to a java 9 compatible version
* force java 9 compatible jruby version for gem-maven-plugin
* fixed classpath issues in tests
* no Java9 specific features are used

Closes asciidoctor#591
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 10, 2018
* updated groovy to a java 9 compatible version
* force java 9 compatible jruby version for gem-maven-plugin
* fixed classpath issues in tests
* no Java9 specific features are used

Closes asciidoctor#591
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 10, 2018
* updated groovy to a java 9 compatible version
* force java 9 compatible jruby version for gem-maven-plugin
* use add-opens to prevent gibberish in the head of the generated pom
* ignore add-opens on older java versions
* fixed classpath issues in tests
* no Java9 specific features are used

Closes asciidoctor#591
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 11, 2018
tisoft added a commit to tisoft/asciidoctorj that referenced this issue Jan 14, 2018
@jmini
Copy link
Contributor

jmini commented Jan 16, 2018

Pull requests:

Thank you @tisoft

I guess this issue can now be closed.

@jmini
Copy link
Contributor

jmini commented Jan 16, 2018

I tested it on windows (see #608)

gradlew.bat publishToMavenLocal -Pskip.signing

FAILURE: Build failed with an exception.

* What went wrong:
Task 'publishToMavenLocal' not found in root project 'asciidoctor'.

* Try:
Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s

Do I need to install a Java 9 JDK in order to run it?

@tisoft
Copy link
Contributor

tisoft commented Jan 16, 2018

No, you don't need Java9. It just doesn't fail to compile on Java 9 anymore (in the 1.6.0 branch)

I just checked the publishToMavenLocal task and it works for me. Could you paste the complete output?

@jmini
Copy link
Contributor

jmini commented Jan 17, 2018

Never mind, my mistake. It works as expected.

@jmini
Copy link
Contributor

jmini commented Feb 21, 2018

Pull request to add java 9 CI on the master branch => #628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants