Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate content model constants on Processor #492

Closed
mojavelinux opened this issue Jul 23, 2016 · 0 comments
Closed

Deprecate content model constants on Processor #492

mojavelinux opened this issue Jul 23, 2016 · 0 comments
Assignees
@robertpanzer
Milestone
v1.6.0

Comments

@mojavelinux
Copy link
Member

Now that the content model constants are defined and organized in the ContentModel class, I don't think we need the equivalent constants on the Processor class anymore. We should either remove the constants on the Processor class or at least mark them as deprecated.

For example, the constant for the the compound content model is defined in these two places:

  • Processor.CONTENT_MODEL_COMPOUND
  • ContentModel.COMPOUND

I also think that ContentModel should be moved to the ast package.
robertpanzer added a commit to robertpanzer/asciidoctorj that referenced this issue Jul 25, 2016
@robertpanzer
Fixes asciidoctor#492. Deprecate Processor.CONTENT_MODEL_* and moved …
d759bcd 
…@ContentModel to org.asciidoctor.ast.
@robertpanzer robertpanzer self-assigned this Jul 25, 2016
@robertpanzer robertpanzer added this to the v1.6.0 milestone Jul 25, 2016
robertpanzer added a commit to robertpanzer/asciidoctorj that referenced this issue Jul 29, 2016
@robertpanzer
Fixes asciidoctor#492. Deprecate Processor.CONTENT_MODEL_* and moved …
6a126f5 
…@ContentModel to org.asciidoctor.ast.
robertpanzer added a commit that referenced this issue Jul 30, 2016
@robertpanzer
Merge pull request #494 from robertpanzer/issue_492
8c79373 
Fixes #492. Deprecate Processor.CONTENT_MODEL_* and moved @ContentMod…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertpanzer robertpanzer

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@mojavelinux @robertpanzer