Images measurements support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(also the old code been a lil dirty imo :))
Returns now a "meta" field instead of two - height and maxheight - fields.
The meta object contains these fields:
```
{
maxHeight: int,
maxWidth: int,
images: [{
height: int,
offsetY: int,
totalHeight: int,
width: int
},...]
}
```
the spriter script. See asciidisco#52 Also did some cleanup to the output string building.
### 0.3.4 + Added width and height properties to the spriter output [@alpadev] (https://github.com/alpadev) - 85a04f5 Updates the generator functions to adopt the changes introduced to the spriter script. See asciidisco#52 [@alpadev] - 6416c26 Rewrote most of it.. to accomplish asciidisco#52 (also the old code been a lil dirty imo :)) [@alpadev]
|
Just pushed an update to make the output optional - defaults to false. |
|
Just checked it, seems fine for me. |
|
@alpadev @LaurentGoderre |
|
Sorry just got home phew.
|
cybear
added a commit
to cybear/grunt-imagine
that referenced
this pull request
May 27, 2014
## Utilize an object FileMeta to contain everything needed for each file. It keeps the original path and supplies helper functions to do everything necessary with each file. ## Use functional style to filter the file list * `filterOnlyImage` Filter out fonts as well as CSS files * `filterOnlyExists` Filter out files that don’t exist * `filterOnlySmall` Filter away large files if IE8 mode activated ## Other fixes * Verify that `fs.exists` instead of opening and using `try…catch` * The path verification didn’t work in my project. I added a method of detecting the path (asciidisco#52) but kept both the other methods (asciidisco#50, asciidisco#54) so as not to break any earlier functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump to 0.3.4
Adds width and height to the spriter output. Also some code cleanup.
See #52