-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting boost temp sometimes errors #4
Comments
Hey Mark, I think I fixed this bug earlier on, which version of HA are you using? |
I am running 103.4 with wiser component 1.7.1. I can send you a PR but think just need to sent to an integer value when we multiply boost temp by 10. Think you have fixed this in the setTemperature method but not in the setRoomMode method. |
Sorry i was probably remembering a previous version where you were removing the decimal point instead of multiplying by 10. It is true that i cannot recreate this issue right now but i think we maybe should do the integer conversion as suggested to ensure we cannot pass a non integer value to the wiser hub. |
Fixed: Error calling temp range check
Mark,. this issue is fixed with your PR right? |
Yes |
I have seen a situation whereby setting the boost temp when calling setRoomMode causes an error from the hub that it is expecting an integer.
I think this is caused by the fact that passing a float value (ie 21.5) to the method maintains a float when passing to the hub.
Line
temp=boost_temp*10
needs to be
temp=int(boost_temp*10)
to ensure this cannot happen
Thx Mark
The text was updated successfully, but these errors were encountered: