Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having 0 TRVs (smartvalves) is a valid configuration #1

Closed
relaystar opened this issue May 2, 2019 · 2 comments
Closed

Having 0 TRVs (smartvalves) is a valid configuration #1

relaystar opened this issue May 2, 2019 · 2 comments

Comments

@relaystar
Copy link

It might not be common, but it is valid, for instance if you buy the 3 zone kit:

https://www.draytoncontrols.co.uk/products/Smart-Heating/Wiser/wiser-thermostat-kit-3

it doesn't come with any TRVs.
@asantaga
Copy link
Owner

asantaga commented May 2, 2019

mmm yeah.. I'll be fixing the code, need it for the HA Project

@msp1974 msp1974 mentioned this issue Jan 11, 2020
Merged
asantaga pushed a commit that referenced this issue Jan 12, 2020
@msp1974
Merge pull request #1 from msp1974/timeout
1c46e8e 
Updated:  Added timeout setting to all requests
asantaga pushed a commit that referenced this issue Jan 12, 2020
@msp1974
Fix for issue #1. Only shows warning if room has no TRVs or RoomStats
2d28fc4
asantaga pushed a commit that referenced this issue Jan 12, 2020
@msp1974
Merge pull request #3 from msp1974/MinorImprovements
87e46eb 
Fix for issue #1.  Only shows warning if room has no TRVs or RoomStats
@asantaga
Copy link
Owner

this is now fixed, having a room with no TRVs no longer gives an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asantaga @relaystar