Copy changes from reduxjs#2168

aryaemami59 · May 3, 2024 · 3fe18e7 · 3fe18e7
1 parent 4d30e85
commit 3fe18e7
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/test/typetests/connect-options-and-issues.test-d.tsx b/test/typetests/connect-options-and-issues.test-d.tsx
@@ -801,13 +801,13 @@ describe('type tests', () => {
       ref={(ref: number) => {}}
     />
 
-    // Should be able to use all refs including legacy string
-    const classLegacyRef: React.LegacyRef<ClassComponent> | undefined =
-      undefined
+    // Should be able to use all refs (except legacy string refs, which go away in React 19)
+    const classLegacyRef: React.Ref<ClassComponent> | undefined = undefined
     ;<ConnectedClassComponent ref={classLegacyRef} />
     ;<ConnectedClassComponent ref={React.createRef<ClassComponent>()} />
     ;<ConnectedClassComponent ref={(ref: ClassComponent) => {}} />
-    ;<ConnectedClassComponent ref={''} />
+    // TODO Can make this an expected error if we target React 19 exclusively
+    // ;<ConnectedClassComponent ref={''} />
     ;<ConnectedClassComponent
       // @ts-expect-error ref type should be the typeof the wrapped component
       ref={React.createRef<string>()}