-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy coords before modifying #2160
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2160 +/- ##
=======================================
Coverage 90.68% 90.68%
=======================================
Files 120 120
Lines 12678 12679 +1
=======================================
+ Hits 11497 11498 +1
Misses 1181 1181
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Small update to changelog and this is ready |
Same comment as @ahartikainen. Thanks for the PR. You only need to add one line to https://github.com/arviz-devs/arviz/blob/main/CHANGELOG.md#maintenance-and-fixes and it will be ready to merge. |
@ahartikainen and @OriolAbril Thank you for the comments. I just added one line to the changelog. Let me know if it works. |
0735687
to
8a91839
Compare
Thanks, everything looks good. I cleaned the commits a bit using |
@ahartikainen Thank you for making the PR much cleaner. Just for a learning purpose, how did you choose the keywords after "git rebase -i upstream/main" ? I guess you "pick" the two remaining commits. Did you drop the other two commits? |
Yes |
Got it, thanks a lot! |
Description
Make a copy of the dictionary coords, so the input parameter coords is not modified.
This PR is to fix the issue mentioned in issue #2047
📚 Documentation preview 📚: https://arviz--2160.org.readthedocs.build/en/2160/