Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue when coords for default dims are provided #2001

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Mar 19, 2022

Description

Currently if coordinate values are provided for "default dims" they are ignored.
This is an issue for example in pymc where posterior and posterior predictive are
separate sampling steps and you can choose to thin the posterior if generating
posterior predictive samples is expensive as it prevents the original
draw/chain ids to be preserved as coordinate values of the posterior predictive.

Checklist

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #2001 (01315ce) into main (9deaa52) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 01315ce differs from pull request most recent head f4bafb4. Consider uploading reports for the commit f4bafb4 to get more accurate results

@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
- Coverage   90.85%   90.81%   -0.05%     
==========================================
  Files         114      114              
  Lines       12332    12332              
==========================================
- Hits        11204    11199       -5     
- Misses       1128     1133       +5     
Impacted Files Coverage Δ
arviz/data/base.py 98.21% <100.00%> (ø)
arviz/__init__.py 87.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9deaa52...f4bafb4. Read the comment docs.

@OriolAbril OriolAbril merged commit 479f2a7 into arviz-devs:main Mar 21, 2022
@OriolAbril OriolAbril deleted the fix_coords_default_dims branch March 21, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants