-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pylint and pickling issue #1743
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1743 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 109 109
Lines 11844 11844
=======================================
Hits 10763 10763
Misses 1081 1081
Continue to review full report at Codecov.
|
This has a new issue now right? PyMC is causing some caching problem? |
Apparently. Usually these fix themselves in a day or two. |
I ran tests locally in multiple envs and they passed so rerunning here |
Noting here as well. PyMC changed to cloud pickle which points to why pickle is failing. Should we make the switch as well? https://github.com/pymc-devs/pymc3/blob/main/pymc3/tests/test_model.py#L410 |
Alright I dont have enough time to figure out mypy but propose we merge this so we can unblock all other PRs. Thoughts? |
pip install $PWD/pymc3 | ||
# python -m pip --no-cache-dir --log log.txt install git+https://github.com/pymc-devs/pymc3 | ||
# cat log.txt | ||
# git clone https://github.com/pymc-devs/pymc3 cd pymc3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can delete the "manual" install method now.
Description
Checklist