Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint and pickling issue #1743

Merged
merged 19 commits into from
Jul 26, 2021
Merged

Fix pylint and pickling issue #1743

merged 19 commits into from
Jul 26, 2021

Conversation

ahartikainen
Copy link
Contributor

Description

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #1743 (c6b5b3b) into main (ae83908) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1743   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files         109      109           
  Lines       11844    11844           
=======================================
  Hits        10763    10763           
  Misses       1081     1081           
Impacted Files Coverage Δ
arviz/data/inference_data.py 83.71% <100.00%> (ø)
arviz/data/io_pyro.py 96.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae83908...c6b5b3b. Read the comment docs.

@canyon289
Copy link
Member

This has a new issue now right? PyMC is causing some caching problem?

@ahartikainen
Copy link
Contributor Author

Apparently. Usually these fix themselves in a day or two.

@canyon289
Copy link
Member

I ran tests locally in multiple envs and they passed so rerunning here

@canyon289
Copy link
Member

Noting here as well. PyMC changed to cloud pickle which points to why pickle is failing. Should we make the switch as well?

https://github.com/pymc-devs/pymc3/blob/main/pymc3/tests/test_model.py#L410

@canyon289
Copy link
Member

Alright I dont have enough time to figure out mypy but propose we merge this so we can unblock all other PRs. Thoughts?

@canyon289 canyon289 changed the title Fix pylint Fix pylint and pickling issue Jul 25, 2021
pip install $PWD/pymc3
# python -m pip --no-cache-dir --log log.txt install git+https://github.com/pymc-devs/pymc3
# cat log.txt
# git clone https://github.com/pymc-devs/pymc3 cd pymc3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete the "manual" install method now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants