upload updated mypy.ini if needed

[ahartikainen]

Description

Checklist

• Follows official PR format
• Includes a sample plot to visually illustrate the changes (only for plot-related functions)
• New features are properly documented (with an example if appropriate)?
• Includes new or updated tests to cover the new feature
• Code style correct (follows pylint and black guidelines)
• Changes are listed in changelog

[codecov]

Codecov Report

Merging #1624 (0d52e39) into main (9420925) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1624   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         108      108           
  Lines       11663    11663           
=======================================
  Hits        10604    10604           
  Misses       1059     1059           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9420925...0d52e39. Read the comment docs.

[ahartikainen]

Hey, it works. If someone else could confirm this too I can remove those non-needed commits and we can merge this.

[canyon289]

So I read this but I dont really get what it does and am confused that you say it works but CI is failing?

For specifica feedback, can we add a comment to yml file explaining what this thing is, even one line helps
And in regards to CI if its failing how do you know it works?

[OriolAbril]

We recently added mypy and typing copilot to CI. mypy checks that the code does not incur in any type errors, which sounds great, however, many parts of our codebase and many of our dependencies do not use type hints everywhere (or at all). Therefore, mypy check relies on a very long and specific mypy.ini file that ensures we make the most of the type hints available without getting any errors due to the missing type hints. typing copilot is what takes care of this file. typing copilot was first used to generate a base mypy.ini file, and now it is also executed on CI to check if we can "tighten" this file, that is, remove some of the ignores because we our our dependencies added type hints. If we can tighten, typing copilot will fail the CI job! This is what is happening now, ci is failing because we can improve our mypy.ini.

The improvement Ari is adding with this PR is that now, whenever typing copilot fails ci, azure will rerun typing copilot, but not as a check, as mypy.ini generator and upload the improved mypy.ini as an artifact. Thus, "fixing" the failing CI will become downloading the updated mypy.ini from azure and adding it to the repo.

Regarding explanation, I'd rather have something added to the dev guide instead of comments, we can all update #1587

[OriolAbril]

I can confirm that the mypy.ini is uploaded and looks great, thanks for this @ahartikainen

[ahartikainen]

Do we add a mention about updating mypy.ini in #1587 or here?

[OriolAbril]

I would do it at #1587, still trying to decide how to organize the doc, but I think we should probably have a section about CI

[obi1kenobi]

Very cool!