Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py to require python >= 3.7 #1608

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Conversation

ahnitz
Copy link
Contributor

@ahnitz ahnitz commented Mar 9, 2021

Arxviz due to its requirement on xarray>=0.16.1 (and possibly for internal reasons as well) in practice has a hard requirement on the python version of >=3.6. However, it is not declared at the moment in the setup.py so the package resolution doesn't notice this through pypi until attempting to satisfy the xarray requirement.

@OriolAbril
Copy link
Member

Thanks, we should first merge #1430 though, otherwise CI will attempt to test on python 3.6. Thanks for the PR, we were planning on adding this to the next release, I am adding this PR to the milestone

@OriolAbril OriolAbril added this to the vNext milestone Mar 9, 2021
@ahnitz
Copy link
Contributor Author

ahnitz commented Mar 9, 2021

@OriolAbril I believe python3.6 should in fact be OK (unless other PRs have already implicitly removed 36 support)

@OriolAbril
Copy link
Member

@ahnitz
Copy link
Contributor Author

ahnitz commented Mar 9, 2021

@OriolAbril Yes, done.

@ahnitz ahnitz changed the title Update setup.py to require python >= 3.6 Update setup.py to require python >= 3.7 Mar 9, 2021
@OriolAbril OriolAbril merged commit 0c9da0f into arviz-devs:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants