-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added significant digits formatter for rope values #1569
Conversation
Hi @OriolAbril can you take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! You have to run black and add it to the changelog, then we can merge it.
What version of black do you have? It should not be modifying any unmodified file 🤔 |
I was having same doubt looks like my package is outdated (its |
You may have to undo the latest commit for this to work. Have you ever done interactive rebase? |
9f6b95b
to
3bf65e0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1569 +/- ##
=======================================
Coverage 90.28% 90.28%
=======================================
Files 105 105
Lines 11403 11405 +2
=======================================
+ Hits 10295 10297 +2
Misses 1108 1108
Continue to review full report at Codecov.
|
* Added significant digits formatter for rope values * Added changelog
Description
Added significant digits formatter for rope values. To fix #1561
Checklist