edit groups in idata.extend #1386
Conversation
|
Good thing we got out CI working! Seems like theres an indentation error hidden in there |
9f8303d to
64f1756
Compare
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
+ Coverage 91.73% 91.74% +0.01%
==========================================
Files 105 105
Lines 10909 10915 +6
==========================================
+ Hits 10007 10014 +7
+ Misses 902 901 -1
Continue to review full report at Codecov.
|
fe7fef8 to
20b07fb
Compare
arviz/data/io_dict.py
Outdated
| @@ -69,11 +69,15 @@ def __init__( | |||
| self.attrs.pop("created_at", None) | |||
| self.attrs.pop("arviz_version", None) | |||
|
|
|||
| @requires("posterior") | |||
| def _init_dict(self, attr_name): | |||
| dict_or_none = getattr(self, attr_name, None) | |||
There was a problem hiding this comment.
should this return empty dict instead of None?
There was a problem hiding this comment.
yeah, much better, it directly takes care about the if else below, thanks!
There was a problem hiding this comment.
now I realized the if else is what does the actual work, for now all attrs are set, but it's nice to have this here in case we extended io_dict.
There was a problem hiding this comment.
Remember to update the block below too
There was a problem hiding this comment.
The block below needs to check for None. This first one catches attributes that have not been set and the one below catches attributes set to None
Description
idata.extenddoes add the groups but does not edit the_groupsattributes which makesidata.posteriorto work butposterioris not shown when printing nor in the html repr.Checklist