Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix io_pymc3 bug when model not passed explicitly #1240

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Jun 13, 2020

Description

if model is not passed explicitly, it is retrieved from the context and stored in self.model, however, currently we check coords/dims in model instead.

Checklist

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #1240 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1240   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files          98       98           
  Lines        9714     9714           
=======================================
  Hits         9050     9050           
  Misses        664      664           
Impacted Files Coverage Δ
arviz/data/io_pymc3.py 93.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31aac4c...76e6d84. Read the comment docs.

Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Oriol 👌

@OriolAbril
Copy link
Member Author

ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants