Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate point estimate posterior plot #1038

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Integrate point estimate posterior plot #1038

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98e91ac
integrated point_estimate in plot_posterior
nitishp25 Jan 29, 2020
fbbfd26
changelog update
nitishp25 Jan 29, 2020
dc5bf16
lint and changelog update
nitishp25 Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
* Rename flat_inference_data_to_dict (#1003)
* Violinplot: fix histogram (#997)
* Convert all instances of SyntaxWarning to UserWarning (#1016)
* Fixed `point_estimate` in `plot_posterior` (#1038)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "fix" instead of "fixed"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, making the changes.


### Deprecation

Expand Down
5 changes: 5 additions & 0 deletions arviz/plots/posteriorplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,11 @@ def plot_posterior(
if not 1 >= credible_interval > 0:
raise ValueError("The value of credible_interval should be in the interval (0, 1]")

if point_estimate == "auto":
point_estimate = rcParams["plot.point_estimate"]
elif point_estimate not in {'mean', 'median', 'mode', None}:
raise ValueError("The value of point_estimate must be either mean, median, mode or None.")

plotters = filter_plotters_list(
list(xarray_var_iter(get_coords(data, coords), var_names=var_names, combined=True)),
"plot_posterior",
Expand Down