Log and continue if err occurs when getting stats

arunvelsriram · Aug 13, 2020 · 3c91e22 · 3c91e22
1 parent 9a129db
commit 3c91e22
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/pkg/collector/sftp_collector.go b/pkg/collector/sftp_collector.go
@@ -71,21 +71,21 @@ func (s SFTPCollector) Collect(ch chan<- prometheus.Metric) {
 	fsStats, err := sftpClient.FSStats()
 	if err != nil {
 		log.WithFields(log.Fields{"event": "getting FS stats"}).Error(err)
-		return
-	}
-	for _, stat := range fsStats {
-		ch <- prometheus.MustNewConstMetric(fsTotalSpace, prometheus.GaugeValue, stat.TotalSpace, stat.Path)
-		ch <- prometheus.MustNewConstMetric(fsFreeSpace, prometheus.GaugeValue, stat.FreeSpace, stat.Path)
+	} else {
+		for _, stat := range fsStats {
+			ch <- prometheus.MustNewConstMetric(fsTotalSpace, prometheus.GaugeValue, stat.TotalSpace, stat.Path)
+			ch <- prometheus.MustNewConstMetric(fsFreeSpace, prometheus.GaugeValue, stat.FreeSpace, stat.Path)
+		}
 	}
 
 	objectStats, err := sftpClient.ObjectStats()
 	if err != nil {
 		log.WithFields(log.Fields{"event": "getting object stats"}).Error(err)
-		return
-	}
-	for _, stat := range objectStats {
-		ch <- prometheus.MustNewConstMetric(objectCount, prometheus.GaugeValue, stat.ObjectCount, stat.Path)
-		ch <- prometheus.MustNewConstMetric(objectSize, prometheus.GaugeValue, stat.ObjectSize, stat.Path)
+	} else {
+		for _, stat := range objectStats {
+			ch <- prometheus.MustNewConstMetric(objectCount, prometheus.GaugeValue, stat.ObjectCount, stat.Path)
+			ch <- prometheus.MustNewConstMetric(objectSize, prometheus.GaugeValue, stat.ObjectSize, stat.Path)
+		}
 	}
 }