Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to v10.15 #3568

Closed
wants to merge 1 commit into from
Closed

Update Node.js to v10.15 #3568

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 18, 2019

This PR contains the following updates:

Package Type Update Change
circleci/node docker minor 10.13 -> 10.15

See full list of changes here.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@zephraph
Copy link
Contributor

Interesting.. I didn't realize this would happen. We have to be cautious with this upgrade because we know that 10.14 causes some issues. @joeyAghion it'd probably be good to look to see if they fixed that issue or if it's still around.

@alloy
Copy link
Contributor

alloy commented Feb 19, 2019

:ceiling-cat: Links to context when referring to known issues would be much appreciated 🙏

@joeyAghion
Copy link
Contributor

We definitely have to be cautious with this upgrade. The corresponding ticket is https://artsyproduct.atlassian.net/browse/PLATFORM-1102, but #3235 was eventually necessary to get things healthy again (as well as artsy/metaphysics#1451 on Metaphysics).

I would review the diff carefully and default to not upgrading unless there are explicit fixes for handling of long-lived TCP connections.

@zephraph zephraph added the Hold label Feb 19, 2019
@alloy
Copy link
Contributor

alloy commented Feb 20, 2019

default to not upgrading unless there are explicit fixes

Agreed. I would also suggest disabling PRs for dependencies like these.

@zephraph
Copy link
Contributor

Looking back at the 14 docs, it looks like there’s a config setting for lengthening the timeout of http requests. server.headersTimeout

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#notable-changes-4

@damassi damassi closed this Feb 24, 2019
@renovate
Copy link
Contributor Author

renovate bot commented Feb 24, 2019

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (10.15). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants