Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(performance): Add INP optimization strategy for mobile web" #15128

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

damassi
Copy link
Member

@damassi damassi commented Jan 29, 2025

Reverts #15096.

Turns out this INP hack/fix didn't actually improve things in google search console, so lets revert and avoid weird hacks that nobody will understand a few years down the line 😢

@damassi damassi requested review from joeyAghion, mzikherman and a team January 29, 2025 06:21
@damassi damassi self-assigned this Jan 29, 2025
Copy link

relativeci bot commented Jan 29, 2025

#1633 Bundle Size — 8.94MiB (-0.02%).

7ebdb07(current) vs db4d317 main#1631(baseline)

Warning

Bundle contains 14 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Improvement 1 improvement
                 Current
#1633
     Baseline
#1631
Improvement  Initial JS 3.62MiB(-0.02%) 3.62MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 50.38% 97.76%
No change  Chunks 105 105
No change  Assets 108 108
Change  Modules 5850(-0.02%) 5851
No change  Duplicate Modules 523 523
Change  Duplicate Code 3.99%(-0.25%) 4%
No change  Packages 266 266
No change  Duplicate Packages 13 13
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#1633
     Baseline
#1631
Regression  JS 8.8MiB (+100%) undefined
Regression  Other 146.65KiB (+100%) undefined

Bundle analysis reportBranch revert-15096-review-app-inp-test...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@nickskalkin nickskalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad

@damassi damassi merged commit 56d5d43 into main Jan 29, 2025
10 of 11 checks passed
@damassi damassi deleted the revert-15096-review-app-inp-test-2 branch January 29, 2025 16:08
@artsy-peril artsy-peril bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants