Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rsbuild): Upgrade RSBuild/RSPack lib ecosystem to 1.2.x #15125

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

damassi
Copy link
Member

@damassi damassi commented Jan 28, 2025

The type of this PR is: Chore

Description

The latest rspack@1.2.0 was released a week or so ago with a lot of nice updates, including a new persistent cache. This enables much quicker initial compilation once a first pass cold compilation has occurred.

They also tweaked their minification strategy (multiple passes on minified code), which should lead to slightly smaller bundle sizes.

Also updates the surrounding ecosystem for compat!

See the blog post for more info: https://rspack.dev/blog/announcing-1-2

cc @artsy/diamond-devs

@damassi damassi self-assigned this Jan 28, 2025
@damassi damassi force-pushed the damassi/chore/upgrade-rspack branch from b6853e8 to 28fa386 Compare January 28, 2025 17:43
Copy link

relativeci bot commented Jan 28, 2025

#1630 Bundle Size — 8.94MiB (-0.8%).

1580805(current) vs 1a43767 main#1627(baseline)

Warning

Bundle contains 14 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Improvement 1 improvement
                 Current
#1630
     Baseline
#1627
Improvement  Initial JS 3.62MiB(-0.72%) 3.65MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 97.76% 42.91%
No change  Chunks 105 105
No change  Assets 108 108
Change  Modules 5849(-0.03%) 5851
No change  Duplicate Modules 523 523
Change  Duplicate Code 4.01%(+0.25%) 4%
No change  Packages 266 266
No change  Duplicate Packages 13 13
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#1630
     Baseline
#1627
Regression  JS 8.79MiB (+100%) undefined
Regression  Other 146.65KiB (+100%) undefined

Bundle analysis reportBranch damassi/chore/upgrade-rspackProject dashboard


Generated by RelativeCIDocumentationReport issue

@damassi damassi force-pushed the damassi/chore/upgrade-rspack branch from 28fa386 to 1580805 Compare January 28, 2025 23:58
@damassi
Copy link
Member Author

damassi commented Jan 29, 2025

Aight, gonna merge 👍

@damassi damassi merged commit db4d317 into main Jan 29, 2025
11 checks passed
@damassi damassi deleted the damassi/chore/upgrade-rspack branch January 29, 2025 00:05
@artsy-peril artsy-peril bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant