feat(EMI-2244): prototype stripe express checkout #15123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSltun
previously approved these changes
Jan 28, 2025
|
EDIT: fixed 👍 I'm a bit confused about the failing legacy test. It may have something to do with updating Stripe. |
#1620 Bundle Size — 8.99MiB (-0.08%).9076794(current) vs 35e2ef1 main#1618(baseline) Warning Bundle contains 14 duplicate packages – View duplicate packages Bundle metrics
|
| Current #1620 |
Baseline #1618 |
|
|---|---|---|
 Initial JS |
3.66MiB(+0.27%) |
3.65MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
67.34% |
47.14% |
| Chunks |
103(-1.9%) |
105 |
| Assets |
106(-1.85%) |
108 |
| Modules |
5838(-0.19%) |
5849 |
| Duplicate Modules |
523 |
523 |
| Duplicate Code |
4%(-0.25%) |
4.01% |
| Packages |
266 |
266 |
| Duplicate Packages |
13 |
13 |
Bundle size by type 2 changes 2 regressions
| Current #1620 |
Baseline #1618 |
|
|---|---|---|
| JS |
8.85MiB (+100%) |
undefined |
| Other |
143.36KiB (+100%) |
undefined |
Bundle analysis report Branch review-app-stripe-express-checko... Project dashboard
Generated by RelativeCI Documentation Report issue
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
This PR solves EMI-2244
Description
This is a simple prototype of the Stripe Express Element to test if Apple Pay works well inside our mobile WebView.
To test use the review app https://stripe-express-checkout-prototype.artsy.net/ in a Safari browser that has a credit card added in your apple wallet.
This is behind the feature flag
emerald_stripe-express-checkout-prototype