Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove find-node.sh from react-native (patch-package) #6458

Conversation

olerichter00
Copy link
Contributor

@olerichter00 olerichter00 commented Mar 18, 2022

The type of this PR is: chore

Description

Removes find-node.sh from from node_modules/react-native/scripts/generate-specs.sh with patch-package to the"Command PhaseScriptExecution failed with a nonzero exit code" build error related to node version managers.

The script seems to be removed completely from newer RN versions (facebook/react-native#33146).

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have tested my changes on iOS and Android.
  • I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
  • I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

@olerichter00
Copy link
Contributor Author

@pvinis I decided to just remove the find-node.sh from the script that caused my build to fail. We could also remove it completely in the patch but I don't see why this would be necessary.

@olerichter00 olerichter00 force-pushed the olerichter00/remove-find-nodesh-from-react-native-patch-package branch 2 times, most recently from 34e2816 to 662310e Compare March 18, 2022 15:33
@olerichter00 olerichter00 force-pushed the olerichter00/remove-find-nodesh-from-react-native-patch-package branch from 662310e to aabb06c Compare March 18, 2022 15:38
@olerichter00
Copy link
Contributor Author

olerichter00 commented Mar 18, 2022

Closing this PR. Removing the unused folder $HOME/.nvm fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants