WIP - Add remote service interactions #6

artl93 · 2024-12-31T20:23:22Z

No description provided.

… it works.

- Improve test runtimes (set FakeTimeProvider dates on start, not using SetUTCNow())

- Updated `GetUserConfigurationForDayAsync` to always enable the remote provider. - Simplified lambda expressions for `RemoteUserStateProvider` and `HiddenForm` in `Program.cs`. - Refactored `IScreenTimeStateClient` creation in `ServiceCollectionExtensions.cs` to directly instantiate `ScreenTimeLocalService`. - Changed `IUserConfigurationProvider` registration logic to check for "develop" or "live" instead of "local" or "live".

- Introduced `SendHeartbeatAsync` method in `IUserConfigurationProvider` and implemented it in `LocalUserConfigurationProvider`. - Updated `RemoteUserConfigurationProvider` to send heartbeat data via HTTP POST. - Modified `SwitchableUserConfigurationProvider` to utilize the new heartbeat method. - Refactored variable declaration in `HiddenForm.cs` for clarity. - Simplified `AddScreenTimeClient` method in `Program.cs` and `ServiceCollectionExtensions` by removing unnecessary parameters. - Added `cacheFileExtension` constant in `RemoteUserStateProvider` for better cache file management. - Enhanced `LogHeartbeat` method in `ScreenTimeLocalService` to log and send heartbeat signals.

Updated solution files `screentime.sln` and `services.sln` to include a new project reference for `ScreenTIme.Common`. Modified `ScreenTimeService.csproj` to utilize functionalities from `ScreenTIme.Common`.

(no backend storage yet)

Copilot

Copilot reviewed 24 out of 39 changed files in this pull request and generated 3 comments.

Files not reviewed (15)

client.sln: Language not supported
screentime.sln: Language not supported
services.sln: Language not supported
src/ScreenTIme.Common/ScreenTIme.Common.csproj: Language not supported
src/ScreenTimeClient/ExtensionResponseArgs.cs: Evaluated as low risk
src/ScreenTimeClient/ComputerStateEventArgs.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/UserConfigurationResponseEventArgs.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/UserConfigurationRegistryReader.cs: Evaluated as low risk
src/ScreenTIme.Common/UserMessage.cs: Evaluated as low risk
src/ScreenTIme.Common/UserConfiguration.cs: Evaluated as low risk
src/ScreenTIme.Common/UserStatus.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/UserConfigurationEventArgs.cs: Evaluated as low risk
src/ScreenTIme.Common/UserActivityState.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/IUserConfigurationReader.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/LocalUserConfigurationProvider.cs: Evaluated as low risk

Comments suppressed due to low confidence (3)

src/ScreenTimeClient/Configuration/SwitchableUserConfigurationProvider.cs:41

Redundant null check for localProvider. It is already initialized in the constructor.

if (localProvider is null)

src/ScreenTimeClient/Configuration/SwitchableUserConfigurationProvider.cs:52

Redundant null check for localProvider. It is already initialized in the constructor.

if (localProvider is null)

src/ScreenTimeClient/Configuration/IUserConfigurationProvider.cs:14

[nitpick] The parameter name 'v' is ambiguous. It should be renamed to something more descriptive, like 'minutes'.

public Task RequestExtensionAsync(int v);

src/ScreenTimeClient/Configuration/RemoteUserConfigurationProvider.cs

src/ScreenTimeClient/Configuration/SwitchableUserConfigurationProvider.cs

…ider.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…thods.

… legacy service

- Add Enumerate Extensions

(No notification system yet.)

Copilot

Copilot reviewed 67 out of 82 changed files in this pull request and generated 2 comments.

Files not reviewed (15)

client.sln: Language not supported
screentime.sln: Language not supported
services.sln: Language not supported
src/ScreenTIme.Common/ScreenTIme.Common.csproj: Language not supported
src/ScreenTimeClient/ComputerStateEventArgs.cs: Evaluated as low risk
src/ScreenTIme.Common/UserMessage.cs: Evaluated as low risk
src/ScreenTIme.Common/UserStatus.cs: Evaluated as low risk
src/ScreenTIme.Common/UserActivityState.cs: Evaluated as low risk
.github/workflows/dotnet-desktop.yml: Evaluated as low risk
src/ScreenTIme.Common/DailyConfiguration.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/DailyConfigurationRegistryReader.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/DailyConfigurationLocalProvider.cs: Evaluated as low risk
src/ScreenTIme.Common/Heartbeat.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/DailyConfigurationEventArgs.cs: Evaluated as low risk
src/ScreenTIme.Common/UserState.cs: Evaluated as low risk

Comments suppressed due to low confidence (4)

src/ScreenTimeClient/Configuration/DailyConfigurationRemoteProvider.cs:8

[nitpick] The parameter name 'connectionProvider' should be consistent with the rest of the class, where 'serviceClient' is used. Rename 'connectionProvider' to 'serviceClient'.

public class DailyConfigurationRemoteProvider(ScreenTimeServiceClient connectionProvider, ILogger<DailyConfigurationRemoteProvider> logger) : IDailyConfigurationProvider, IDisposable

src/ScreenTimeClient/Configuration/ClientConfigurationRegistryReader.cs:7

The variable name _baseKey should be renamed to BaseKey to follow naming conventions.

const string _baseKey = @"HKEY_CURRENT_USER\Software\ScreenTime";

src/ScreenTimeClient/Configuration/ClientConfigurationRegistryReader.cs:18

[nitpick] The method name GetRegistryIntValue should be reviewed for clarity and consistency.

private static int GetRegistryIntValue(string key, string valueName, int defaultValue)

src/ScreenTIme.Common/Extensions.cs:12

The parameter name 'requestId' should be renamed to 'RequestId' to follow the PascalCase naming convention.

public record AdminExtensionRequest(Guid requestId, User User, DateTimeOffset SubmissionDate, TimeSpan Duration);

src/ScreenTimeClient/Configuration/DailyConfigurationRemoteProvider.cs

Copilot · 2025-01-04T03:55:45Z

.github/workflows/dotnet-service.yml

+
+    # Build the application to populate the obj folder with RuntimeIdentifiers
+    - name: Build the application
+      run: dotnet build $env:Solution_Name 


The build command does not correctly use the Configuration environment variable. It should be passed as an argument to the dotnet build command.

Suggested change

run: dotnet build $env:Solution_Name

run: dotnet build $env:Solution_Name --configuration ${{ matrix.configuration }}

…lar)

Copilot reviewed 70 out of 85 changed files in this pull request and generated no comments.

Files not reviewed (15)

client.sln: Language not supported
screentime.sln: Language not supported
services.sln: Language not supported
src/ScreenTIme.Common/ScreenTIme.Common.csproj: Language not supported
src/ScreenTimeClient/Configuration/DailyConfigurationLocalProvider.cs: Evaluated as low risk
.github/workflows/dotnet-service.yml: Evaluated as low risk
src/ScreenTIme.Common/DailyConfiguration.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/DailyConfigurationRemoteProvider.cs: Evaluated as low risk
src/ScreenTimeClient/Configuration/DailyConfigurationRegistryReader.cs: Evaluated as low risk
src/ScreenTimeClient/ComputerStateEventArgs.cs: Evaluated as low risk
src/ScreenTIme.Common/UserMessage.cs: Evaluated as low risk
src/ScreenTIme.Common/UserStatus.cs: Evaluated as low risk
src/ScreenTIme.Common/UserActivityState.cs: Evaluated as low risk
.github/workflows/dotnet-desktop.yml: Evaluated as low risk
src/ScreenTIme.Common/Heartbeat.cs: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/ScreenTimeClient/Configuration/ClientConfigurationRegistryReader.cs:25

The 'else' statement after 'if (objectValue == null)' is redundant and can be removed for cleaner code.

else if (objectValue is int intValue)

artl93 added 19 commits December 29, 2024 00:44

WIP - hack authentication for my tenant into the client to verifythat…

248f8a5

… it works.

WIP started playingwith request APIs

227a7df

Fix await

9f7f0eb

Merge branch 'main' into remote-approvals

5a39818

Update .gitignore

cb4e2c2

Merge branch 'main' into remote-approvals

b3c14a9

General cleanup

8457c99

Rename UserConfigurationProvider to LocalConfigurationProvider

3e6ca52

- Fixup namespaces.

6318016

- Improve test runtimes (set FakeTimeProvider dates on start, not using SetUTCNow())

WIP - refactor remote services from HiddenForm into their own classes

ba86cf4

WIP - Add remote / local switcher

1d83e57

Refactor common record types into a common assembly

d8d9b6f

Add ScreenTIme.Common project reference

b43ea29

Updated solution files `screentime.sln` and `services.sln` to include a new project reference for `ScreenTIme.Common`. Modified `ScreenTimeService.csproj` to utilize functionalities from `ScreenTIme.Common`.

Rename fields

d05746d

Move Heartbeat to ScreenTime.Common

0fb20e1

Heartbeat is now working end-to-end

f5f97ae

(no backend storage yet)

Rename RemoteUserConfigurationProvicer to ScreenTimeServiceClient

93eb5bc

artl93 requested a review from Copilot January 2, 2025 00:37

Copilot AI reviewed Jan 2, 2025

View reviewed changes

artl93 and others added 9 commits January 1, 2025 17:41

Update src/ScreenTimeClient/Configuration/RemoteUserConfigurationProv…

96516cd

…ider.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/ScreenTimeClient/Configuration/RemoteUserConfigurationProv…

d4a1b1d

…ider.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Github copilot led me wrong - I didn't check - these weren't async me…

50d72c8

…thods.

Add verification builds

ef90cad

WIP - screentimeservice is all up to date with the EF models from the…

cee21e8

… legacy service

Remove unused "name" field from user configuration

f99a058

Separate client configuration from user's daily limits / configuation

1d04eba

Back to working

43c868a

Remove old database concepts.

ffc25f2

artl93 added 5 commits January 3, 2025 15:42

Remove old types

9b4caa2

Updated models to represent new reality. And it works.

ed86562

Updated models and ensured heartbeat works.

7baa8e5

- Add Request Extensions

b520146

- Add Enumerate Extensions

Service can now to approvals and denials.

a557a36

(No notification system yet.)

artl93 requested a review from Copilot January 4, 2025 03:54

Copilot AI reviewed Jan 4, 2025

View reviewed changes

Sending a message using SignalR actually kind of works now (using Sca…

2baa97d

…lar)

artl93 requested a review from Copilot January 6, 2025 07:05

Copilot AI reviewed Jan 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP - Add remote service interactions #6

WIP - Add remote service interactions #6

artl93 commented Dec 31, 2024

Copilot AI left a comment

Copilot AI left a comment

Copilot AI Jan 4, 2025

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

	run: dotnet build $env:Solution_Name
	run: dotnet build $env:Solution_Name --configuration ${{ matrix.configuration }}

WIP - Add remote service interactions #6

Are you sure you want to change the base?

WIP - Add remote service interactions #6

Conversation

artl93 commented Dec 31, 2024

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Jan 4, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment