[Kafka] Refactor the way we handle Kafka connections #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danafallon
reviewed
Jul 11, 2024
| return dialer, nil | ||
| } | ||
|
|
||
| func (c Connection) Transport() (*kafka.Transport, error) { |
There was a problem hiding this comment.
Is this used anywhere yet?
There was a problem hiding this comment.
No, I want to use it here though: https://github.com/artie-labs/reader/pull/434
danafallon
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a
Connectionstruct that can be turned into a Dialer and Writer.This will remove the boilerplate in our dashboard and Reader.