Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENTRYPOINT to Dockerfile #787

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

nathan-artie
Copy link
Contributor

No description provided.

@nathan-artie nathan-artie requested a review from Tang8330 July 9, 2024 04:35
@@ -1,2 +1,3 @@
FROM --platform=linux/amd64 alpine:3.20
COPY transfer /transfer
ENTRYPOINT ["/transfer"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this going to work if we need to pass in a config file via the CLI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commands you enter in the CLI are appended to the ENTRYPOINT.

@nathan-artie nathan-artie merged commit 9471510 into master Jul 9, 2024
3 checks passed
@nathan-artie nathan-artie deleted the nv/add-entrypoint-to-dockerfile branch July 9, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants