Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify parseField #410

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Simplify parseField #410

merged 2 commits into from
Apr 8, 2024

Conversation

nathan-artie
Copy link
Contributor

Added all the types from typesThatRequireTypeCasting to the default case in parseField so that typesThatRequireTypeCasting is no longer needed.

@nathan-artie nathan-artie marked this pull request as ready for review April 6, 2024 09:31
@nathan-artie nathan-artie requested a review from Tang8330 April 6, 2024 09:31
Tang8330
Tang8330 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@Tang8330 Tang8330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@nathan-artie nathan-artie merged commit bc2d0fb into master Apr 8, 2024
1 check passed
@nathan-artie nathan-artie deleted the nv/simplify-parse-field branch April 8, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tang8330 Tang8330 Tang8330 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathan-artie @Tang8330