Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing Staticcheck #233

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Addressing Staticcheck #233

merged 4 commits into from
Dec 14, 2023

Conversation

Tang8330
Copy link
Contributor

@Tang8330 Tang8330 commented Dec 14, 2023 •
edited
Loading

Addressing more staticchecks and reducing code smell, also adding a new command in Makefile so we can do make static

@Tang8330 Tang8330 marked this pull request as ready for review December 14, 2023 21:56
@Tang8330 Tang8330 merged commit 31f303d into master Dec 14, 2023
1 check passed
@Tang8330 Tang8330 deleted the address-static-checks branch December 14, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-artie nathan-artie nathan-artie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tang8330 @nathan-artie