Renaming data types and files #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
commented
Jan 29, 2025
| @@ -90,7 +90,7 @@ func (s *Store) Append(ctx context.Context, tableData *optimization.TableData, u | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *Store) PrepareTemporaryTable(ctx context.Context, tableData *optimization.TableData, dwh *types.DwhTableConfig, tempTableID sql.TableIdentifier, _ sql.TableIdentifier, opts types.AdditionalSettings, createTempTable bool) error { | |||
| func (s *Store) PrepareTemporaryTable(ctx context.Context, tableData *optimization.TableData, dwh *types.DestinationTableConfig, tempTableID sql.TableIdentifier, _ sql.TableIdentifier, opts types.AdditionalSettings, createTempTable bool) error { | |||
There was a problem hiding this comment.
Renamed DwhTableConfig -> DestinationTableConfig
Tang8330
commented
Jan 29, 2025
| @@ -40,7 +40,7 @@ const ( | |||
| type Store struct { | |||
| // If [auditRows] is enabled, we will perform an additional query to ensure that the number of rows in the temporary table matches the expected number of rows. | |||
| auditRows bool | |||
| configMap *types.DwhToTablesConfigMap | |||
| configMap *types.DestinationTableConfigMap | |||
There was a problem hiding this comment.
Renamed DwhToTablesConfigMap -> DestinationTableConfigMap
Tang8330
commented
Jan 29, 2025
| columns: columns.NewColumns(cols), | ||
| columnsToDelete: make(map[string]time.Time), | ||
| createTable: len(cols) == 0, | ||
| dropDeletedColumns: dropDeletedColumns, | ||
| } | ||
| } | ||
|
|
||
| // SetColumnsToDelete - This is used by tests only | ||
| func (d *DwhTableConfig) SetColumnsToDelete(cols map[string]time.Time) { | ||
| func (d *DestinationTableConfig) SetColumnsToDeleteForTest(cols map[string]time.Time) { |
Tang8330
commented
Jan 29, 2025
| if !isOk { | ||
| return nil | ||
| } | ||
|
|
||
| return tableConfig | ||
| } | ||
|
|
||
| func (d *DwhToTablesConfigMap) RemoveTableFromConfig(tableID sql.TableIdentifier) { | ||
| func (d *DestinationTableConfigMap) RemoveTable(tableID sql.TableIdentifier) { |
Tang8330
commented
Jan 29, 2025
| } | ||
|
|
||
| func (d *DwhToTablesConfigMap) AddTableToConfig(tableID sql.TableIdentifier, config *DwhTableConfig) { | ||
| func (d *DestinationTableConfigMap) AddTable(tableID sql.TableIdentifier, config *DestinationTableConfig) { |
Tang8330
commented
Jan 29, 2025
| sync.RWMutex | ||
| } | ||
|
|
||
| func (d *DwhToTablesConfigMap) TableConfigCache(tableID sql.TableIdentifier) *DwhTableConfig { | ||
| func (d *DestinationTableConfigMap) GetTableConfig(tableID sql.TableIdentifier) *DestinationTableConfig { |
danafallon
reviewed
Jan 29, 2025
lib/destination/types/types_test.go
Outdated
| @@ -15,44 +15,44 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
| ) | |||
|
|
|||
| func generateDwhTableCfg() *types.DwhTableConfig { | |||
| func generateDwhTableCfg() *types.DestinationTableConfig { | |||
There was a problem hiding this comment.
Want to rename this function too? (nit)
danafallon
approved these changes
Jan 29, 2025
stitch-marinus
pushed a commit
to Stitch-Money/transfer
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.