PR Feedback.

artie-labs · Sep 26, 2024 · f5d0e6e · f5d0e6e
1 parent 3bcc60b
commit f5d0e6e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/models/event/event.go b/models/event/event.go
@@ -103,15 +103,14 @@ func ToMemoryEvent(event cdc.Event, pkMap map[string]any, tc kafkalib.TopicConfi
 }
 
 // EmitExecutionTimeLag - This will check against the current time and the event execution time and emit the lag.
-func (e *Event) EmitExecutionTimeLag(metricsClient base.Client, mode config.Mode) {
+func (e *Event) EmitExecutionTimeLag(metricsClient base.Client) {
 	metricsClient.GaugeWithSample(
 		"row.execution_time_lag",
 		float64(time.Since(e.executionTime).Milliseconds()),
 		map[string]string{
-			"mode":  mode.String(),
+			"mode":  e.mode.String(),
 			"table": e.Table,
-		},
-		0.5)
+		}, 0.5)
 }
 
 func (e *Event) Validate() error {

diff --git a/processes/consumer/process.go b/processes/consumer/process.go
@@ -74,7 +74,7 @@ func (p processArgs) process(ctx context.Context, cfg config.Config, inMemDB *mo
 	}
 
 	// Emit execution time lag for non-skipped events.
-	evt.EmitExecutionTimeLag(metricsClient, cfg.Mode)
+	evt.EmitExecutionTimeLag(metricsClient)
 	shouldFlush, flushReason, err := evt.Save(cfg, inMemDB, topicConfig.tc, p.Msg)
 	if err != nil {
 		tags["what"] = "save_fail"