Skip to content

Commit

Permalink
PR Feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
Tang8330 committed Sep 16, 2024
1 parent 9cd523b commit 6e3fc60
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions lib/typing/ext/parse.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,29 +38,29 @@ func ParseFromInterface(val any, kindType ExtendedTimeKindType) (*ExtendedTime,
}
}

func ParseExtendedDateTime(val string, kindType ExtendedTimeKindType) (*ExtendedTime, error) {
func ParseExtendedDateTime(value string, kindType ExtendedTimeKindType) (*ExtendedTime, error) {
switch kindType {
case DateTimeKindType:
return parseDateTime(val)
return parseDateTime(value)
case DateKindType:
// Try date first
if et, err := parseDate(val); err == nil {
if et, err := parseDate(value); err == nil {
return et, nil
}

// If that doesn't work, try timestamp
if et, err := parseDateTime(val); err == nil {
if et, err := parseDateTime(value); err == nil {
et.nestedKind = Date
return et, nil
}
case TimeKindType:
// Try time first
if et, err := parseTime(val); err == nil {
if et, err := parseTime(value); err == nil {
return et, nil
}

// If that doesn't work, try timestamp
if et, err := parseDateTime(val); err == nil {
if et, err := parseDateTime(value); err == nil {
et.nestedKind = Time
return et, nil
}
Expand Down

0 comments on commit 6e3fc60

Please sign in to comment.