Adding tests.

artie-labs · Dec 16, 2023 · 3232865 · 3232865
1 parent 1194ea5
commit 3232865
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/lib/typing/redshift.go b/lib/typing/redshift.go
@@ -64,7 +64,7 @@ func kindToRedShift(kd KindDetails) string {
 		return "VARCHAR(MAX)"
 	case String.Kind:
 		if kd.OptionalRedshiftStrPrecision != nil {
-			return fmt.Sprintf("VARCHAR(%d)", kd.OptionalRedshiftStrPrecision)
+			return fmt.Sprintf("VARCHAR(%d)", *kd.OptionalRedshiftStrPrecision)
 		}
 
 		return "VARCHAR(MAX)"

diff --git a/lib/typing/typing_kind_test.go b/lib/typing/typing_kind_test.go
@@ -1,5 +1,10 @@
 package typing
 
+import (
+	"github.com/artie-labs/transfer/lib/config/constants"
+	"github.com/artie-labs/transfer/lib/ptr"
+)
+
 func (t *TypingTestSuite) Test_KindToDWHType() {
 	type _tc struct {
 		kd                    KindDetails
@@ -15,11 +20,20 @@ func (t *TypingTestSuite) Test_KindToDWHType() {
 			expectedBigQueryType:  "string",
 			expectedRedshiftType:  "VARCHAR(MAX)",
 		},
+		{
+			kd: KindDetails{
+				Kind:                         String.Kind,
+				OptionalRedshiftStrPrecision: ptr.ToInt(12345),
+			},
+			expectedSnowflakeType: "string",
+			expectedBigQueryType:  "string",
+			expectedRedshiftType:  "VARCHAR(12345)",
+		},
 	}
 
 	for idx, tc := range tcs {
-		t.Equal(tc.expectedSnowflakeType, kindToSnowflake(tc.kd), idx)
-		t.Equal(tc.expectedBigQueryType, kindToBigQuery(tc.kd), idx)
-		t.Equal(tc.expectedRedshiftType, kindToRedShift(tc.kd), idx)
+		t.Equal(tc.expectedSnowflakeType, KindToDWHType(tc.kd, constants.Snowflake), idx)
+		t.Equal(tc.expectedBigQueryType, KindToDWHType(tc.kd, constants.BigQuery), idx)
+		t.Equal(tc.expectedRedshiftType, KindToDWHType(tc.kd, constants.Redshift), idx)
 	}
 }