Handle 204 no content responses (#110)

artie-labs · Jan 3, 2025 · b0a92bb · b0a92bb
1 parent 0bd014f
commit b0a92bb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/artieclient/client.go b/internal/artieclient/client.go
@@ -87,11 +87,11 @@ func (c Client) makeRequest(ctx context.Context, method string, path string, bod
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode != http.StatusOK {
+	if resp.StatusCode >= 300 {
 		return buildError(resp)
 	}
 
-	if out != nil {
+	if out != nil && resp.StatusCode != http.StatusNoContent {
 		if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
 			return fmt.Errorf("artie-client: failed to decode response body: %w", err)
 		}