Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bitrot #143

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Fix bitrot #143

merged 3 commits into from
Jan 2, 2023

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Jan 2, 2023

Get CI passing again and remove dependencies on actions-rs GitHub Actions.

CI has been red since October 11, 2022.

`cactusref` is branched from `std::rc` as of
rust-lang/rust@f586d79.

This commit first appeared in Rust 1.55.0. Clippy requires
`rust-version` to point to a toolchain that supports the edition in the
`Cargo.toml` file. The first such toolchain is Rust 1.56.0.

This will prevent clippy from triggering lints which might cause our
fork to drift from where it was branched like let-else or f strings.
@lopopolo lopopolo added A-build Area: CI build infrastructure. C-quality Category: Refactoring, cleanup, and quality improvements. labels Jan 2, 2023
@lopopolo lopopolo merged commit fa6b886 into trunk Jan 2, 2023
@lopopolo lopopolo deleted the lopopolo/revive branch January 2, 2023 06:38
@lopopolo
Copy link
Member Author

lopopolo commented Jan 2, 2023

with this PR merged and CI green, admin bypass for merging has been disabled in this repository.

@lopopolo lopopolo mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: CI build infrastructure. C-quality Category: Refactoring, cleanup, and quality improvements.
Development

Successfully merging this pull request may close these issues.

1 participant