Skip to content

Commit

Permalink
vulkan: remove use of null initializer (ggerganov#10372)
Browse files Browse the repository at this point in the history
Seems like this isn't working for vulkan-over-metal when the array is sized
by a spec constant. Maybe a spirv-cross limitation?
  • Loading branch information
jeffbolznv authored and arthw committed Dec 20, 2024
1 parent 9e4af2d commit f3d8b63
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions ggml/src/ggml-vulkan/vulkan-shaders/mul_mat_vec.comp
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
#endif
#extension GL_EXT_shader_explicit_arithmetic_types_int32 : require

#extension GL_EXT_null_initializer : enable

#include "mul_mat_vec_base.comp"

layout(local_size_x_id = 0, local_size_y = 1, local_size_z = 1) in;
Expand Down Expand Up @@ -57,7 +55,11 @@ void compute_outputs(const uint32_t first_row, const uint32_t num_rows) {

y_offset = QUANT_R == 1 ? 1 : QUANT_K/2;

FLOAT_TYPE temp[NUM_ROWS] = {};
FLOAT_TYPE temp[NUM_ROWS];

for (uint i = 0; i < NUM_ROWS; ++i) {
temp[i] = FLOAT_TYPE(0);
}

const int unroll_count = 8;

Expand Down

0 comments on commit f3d8b63

Please sign in to comment.