Pull out API id and hash as runtime configurable parameters #129
+21
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But someone who builds and publishes packages (such as myself) must still be able to specify API key at compile time so that users won't have to. |
|
Do you mean "specify an alternate default API key" at compile time? |
|
Yes, a package built by me should use my personal API key at least by default. |
|
Already adjusted the patch to cater to that use case. |
|
Hello, |
|
Hey everyone and especially zer0def, I've collected all open PRs into my master branch. I don't make any promises about keeping it up-to-date though. https://github.com/BenWiederhake/tdlib-purple/#new-libpurple-plugin-for-telegram |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since bumping tdlib-purple against tdlib>=1.7, users can experience
14:09 <@root> telegram-tdlib - Login error: Authentication error: code 400 (API_ID_PUBLISHED_FLOOD), which may necessitate them to generate their own API keys and recompile tdlib-purple with-DAPI_ID=<id> -DAPI_HASH=<hash>.This patch moves these parameters from being specified at compile time to run time.