Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weeks to catalan locale #1189

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add weeks to catalan locale #1189

merged 1 commit into from
Oct 24, 2024

Conversation

rimu
Copy link
Contributor

@rimu rimu commented Sep 30, 2024

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

Description of Changes

Hopefully a trivial change that doesn't require tests, etc

Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to arrow @rimu

Can you add some tests for this?

Cheers!

@jadchaar
Copy link
Member

@rimu would it be possible to add some unit tests? Then we can merge this in.

@rimu
Copy link
Contributor Author

rimu commented Oct 19, 2024

No sorry, I don't think it's worth it for such a trivial change.

@jadchaar jadchaar merged commit 540182a into arrow-py:master Oct 24, 2024
18 checks passed
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (403c29f) to head (dbd6949).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2324      2324           
  Branches       357       357           
=========================================
  Hits          2324      2324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants