Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Nullable zip method in favour of DSL #2983

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

gutiory
Copy link
Collaborator

@gutiory gutiory commented Mar 16, 2023

This PR implements the issue
Unfortunately, the replacement is not working with implicit function parameters 😞 .

Nullable.zip(a) { it + 1 }

Is replaced by

nullable<Int> { it + 1 }

Instead of

nullable { x.bind() + 1 }

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

Kover Report

File Coverage [100.00%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Nullable.kt 100.00%
Total Project Coverage 42.95%

Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes

@gutiory gutiory requested review from franciscodr and nomisRev and removed request for franciscodr March 16, 2023 21:19
Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gutiory!

@arrow-kt arrow-kt deleted a comment from rafaparadela Mar 16, 2023
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gutiory 🙌

@nomisRev nomisRev merged commit 42c78ea into main Mar 17, 2023
@nomisRev nomisRev deleted the jg-deprecate-nullable-zip branch March 17, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants