Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show link text instead of link text and URL in documentation #2961

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Show link text instead of link text and URL in documentation #2961

merged 2 commits into from
Mar 15, 2023

Conversation

sesamzoo
Copy link
Contributor

@sesamzoo sesamzoo commented Mar 7, 2023

Just a minor patch removing a comma that probably wasn't supposed to be there.

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sesamzoo,
Thank you for the fix and congrats on your first contribution 🙌

@nomisRev nomisRev requested review from franciscodr, i-walker, raulraja, serras and a team March 7, 2023 19:02
@sesamzoo
Copy link
Contributor Author

sesamzoo commented Mar 8, 2023

@nomisRev what's the preferred way to update PR branches,

  1. merge or
  2. rebase

with main?

@nomisRev
Copy link
Member

nomisRev commented Mar 8, 2023

Regular merge is fine, we squash PR commits when merging into main. That way you don't have to bother with rebase and force pushing.

@serras serras merged commit 99df93f into arrow-kt:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants