Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Either.isLeft, Either.isRight & Option.isSome contract #2937

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix Either.isLeft, Either.isRight & Option.isSome contract #2937

merged 1 commit into from
Feb 21, 2023

Conversation

nomisRev
Copy link
Member

Fixes #2936 reported by @Zordid for both Either and Option.

@nomisRev nomisRev requested review from serras, raulraja, franciscodr and a team February 21, 2023 10:50
franciscodr
franciscodr approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nomisRev!

@github-actions
Copy link
Contributor

Kover Report

File Coverage [51.52%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt 57.39%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Option.kt 44.30%
Total Project Coverage 43.68%

@nomisRev nomisRev merged commit d210349 into main Feb 21, 2023
@nomisRev nomisRev deleted the sv-fix-either-contract branch February 21, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serras serras serras approved these changes

@franciscodr franciscodr franciscodr approved these changes

@gutiory gutiory gutiory approved these changes

@myuwono myuwono myuwono approved these changes

@raulraja raulraja Awaiting requested review from raulraja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract statement is incorrect in Either.isRight(predicate: ...)
5 participants
@nomisRev @serras @franciscodr @gutiory @myuwono