Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise Github Actions #2454

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Optimise Github Actions #2454

merged 3 commits into from
Jul 26, 2021

Conversation

nomisRev
Copy link
Member

This PR changes a couple things to make deduplicate some tasks we run more than once on CI.

  • Remove jvm from build step and turn it into build_js.
  • Rename build/verify steps to running tests, since we removed ktlint and splits running the different platforms in different actions.
  • Run KtLint only once in documentation step

@nomisRev nomisRev requested review from pablisco, rachelcarmena and a team July 25, 2021 17:34
@nomisRev
Copy link
Member Author

Build to build js time seemed to have bring the longest task from 18m to 10m 🥳

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great improvement on times, thanks @nomisRev !

@nomisRev nomisRev merged commit 71d48e1 into main Jul 26, 2021
@nomisRev nomisRev deleted the sv-optimise-build-step branch July 26, 2021 12:44
nomisRev added a commit that referenced this pull request Aug 2, 2021
* Remove jvm from build step and turn it into build_js.
* Rename build/verify steps to running tests, since we removed ktlint and splits running the different platforms in different actions.
* Run KtLint only once in the documentation step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants