Resource parZip & fromAutoCloseable #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
approved these changes
Jul 25, 2021
| public fun <B, C> parZip(fb: Resource<B>, f: (A, B) -> C): Resource<C> = | ||
| parZip(Dispatchers.Default, fb, f) | ||
|
|
||
| /** |
There was a problem hiding this comment.
Perhaps we should add similar comments with examples to other members in the data type that are public https://arrow-kt.io/docs/apidocs/arrow-fx-coroutines/arrow.fx.coroutines/-resource/map.html
i-walker
reviewed
Jul 26, 2021
| public fun <A : Closeable> Resource.Companion.fromCloseable(f: suspend () -> A): Resource<A> = | ||
| Resource(f) { s, _ -> withContext(Dispatchers.IO) { s.close() } } | ||
|
|
||
| @Deprecated("Typo in the function name, use fromCloseable instead.", ReplaceWith("Resource.fromCloseable(f)")) | ||
| public fun <A : Closeable> Resource.Companion.fromClosable(f: suspend () -> A): Resource<A> = |
There was a problem hiding this comment.
😅 Good eyes you have !!
Thanks👍🏾
i-walker
approved these changes
Jul 26, 2021
nomisRev
added a commit
that referenced
this pull request
Aug 2, 2021
* fix docs * Add Resourc parZip * Uncomment test, and remove deprecated usage * Fix JS CancellationException ambiguity * Replace shouldThrow with assertThrowable for JS runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
ResourceparZip. This will allows for encodingparZiptoarity-9, addparTraverseResource` etc.AutoCloseable, which was missing next toCloseable.mapoperator to supportsuspendand addstapcombinator.