Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JS for Arrow Optics #2441

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Support JS for Arrow Optics #2441

merged 3 commits into from
Jul 8, 2021

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Jul 6, 2021 •
edited
Loading

Add Kotlin JS support for Arrow Optics.
Also fixes an open standing bug in Optics.

@nomisRev nomisRev added the MPP Tickets belonging to Arrow Multiplatform Support label Jul 6, 2021
@nomisRev
Copy link
Member Author

nomisRev commented Jul 6, 2021

:arrow-optics:jsLegacyBrowserTest: java.lang.IllegalStateException: command '/Users/runner/.gradle/nodejs/node-v14.15.4-darwin-x64/bin/node' exited with errors (exit code: 1)

I see all JS & JVM tests pass locally, but clean build is failing locally with same error 🤷

@nomisRev nomisRev requested review from danimontoya, franciscodr, i-walker and a team July 8, 2021 21:43
raulraja
raulraja approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nomisRev !

i-walker
i-walker approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@i-walker i-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏾

@i-walker i-walker merged commit 2569ece into main Jul 8, 2021
@i-walker i-walker deleted the sv-js-optics branch July 8, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@i-walker i-walker i-walker approved these changes

@danimontoya danimontoya Awaiting requested review from danimontoya

@franciscodr franciscodr Awaiting requested review from franciscodr

Assignees
No one assigned
Labels
MPP Tickets belonging to Arrow Multiplatform Support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomisRev @raulraja @i-walker