Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate parTraverse in favor of parMap #2788

Closed
5 tasks
nomisRev opened this issue Aug 4, 2022 · 3 comments · Fixed by #2863
Closed
5 tasks

Deprecate parTraverse in favor of parMap #2788

nomisRev opened this issue Aug 4, 2022 · 3 comments · Fixed by #2863
Assignees
@nomisRev

Comments

@nomisRev
Copy link
Member

nomisRev commented Aug 4, 2022

  • Rename parTraverse to parMap
  • Remove parTraverse signatures that don't preserve the correct CoroutineDispatcher context
  • Remove parTraverseEither
  • Remove parTraverseResult
  • Rename parTraverseValidated to parMapAccumulating, and use Either#mapAccumulating instead.
@serras serras mentioned this issue Aug 9, 2022
Merged
20 tasks
@Atternatt Atternatt mentioned this issue Sep 13, 2022
Merged
Atternatt added a commit to Atternatt/arrow that referenced this issue Sep 28, 2022
@Atternatt
refactor(arrow2): Rename parTraverse to parMap
f518e50 
Related issue id: arrow-kt#2788
Atternatt added a commit to Atternatt/arrow that referenced this issue Sep 28, 2022
@Atternatt
move(arrow2): Rename parTraverse to parMap
59e3358 
Related issue id: arrow-kt#2788
Atternatt added a commit to Atternatt/arrow that referenced this issue Sep 28, 2022
@Atternatt
doc(arrow2): Add knit samples
e25348b 
Related issue id: arrow-kt#2788
@serras
Copy link
Member

serras commented Dec 5, 2022

Fixed by #2795

@serras serras closed this as completed Dec 5, 2022
@nomisRev nomisRev reopened this Dec 5, 2022
@nomisRev
Copy link
Member Author

nomisRev commented Dec 5, 2022

This didn't happen in #2795, and needs to still happen. A couple fixes have to be made to parTraverse in order to preserve context in a similar was as KotlinX Coroutine does.

This can however happen in 1.x.x straight away, so I am removing Arrow 2.0 from the issue name.

@nomisRev nomisRev changed the title [Arrow 2.0] Replace parTraverse with parMap Deprecate parTraverse in favor of parMap Dec 5, 2022
@nomisRev nomisRev assigned nomisRev and unassigned Atternatt Dec 5, 2022
This was referenced Dec 5, 2022
Closed
Merged
@thejeff77
Copy link

The documentation does not mention deprecation or the new method FYI.

https://old.arrow-kt.io/docs/apidocs/arrow-fx-coroutines/arrow.fx.coroutines/par-traverse-n.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nomisRev nomisRev

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@serras @Atternatt @thejeff77 @nomisRev