Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an ability to specify app flags in azure terraform #267

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

predivan2022
Copy link
Contributor

Description

This PR adds an ability to explicitly specify db1000n flags in Azure terraform scripts. It might be very useful in case if custom config is required to be used.

Usage

Specify attack_commands variable in terraform.tfvars
``
attack_commands = ["/usr/src/app/main","-c=https://link_to_config"]
`

@predivan2022 predivan2022 requested a review from arriven as a code owner March 9, 2022 16:44
@arriven
Copy link
Owner

arriven commented Mar 9, 2022

To improve stability I would like all changes that are not covered by CI to be vet by someone other than the author who's already using the corresponding guide. This particular change seems less risky so I'll probably merge it in couple hours anyway but would be nice to follow the procedure anyway

@arriven arriven added the triage needed This issue/PR needs to be checked by someone to confirm it's correct label Mar 9, 2022
@arriven arriven merged commit 54677f9 into arriven:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage needed This issue/PR needs to be checked by someone to confirm it's correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants