Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added dash to allowable application name regex #41

Merged
merged 1 commit into from
Jan 14, 2020
Merged

added dash to allowable application name regex #41

merged 1 commit into from
Jan 14, 2020

Conversation

parondeau
Copy link
Contributor

No description provided.

@dotdotdotpaul
Copy link

Last I checked, Spinnaker application names weren't allowed to have hyphens in them.

@parondeau
Copy link
Contributor Author

Last I checked, Spinnaker application names weren't allowed to have hyphens in them.

AFAIK you still can. Reported issue here: #40

I have many applications with dashes in the name created via UI and terraform (older version of this plugin, before this restriction was added).

In their documentation they use my-app as the example application name: https://www.spinnaker.io/guides/spin/app/#create-a-new-application-using-save

@parondeau parondeau marked this pull request as ready for review January 13, 2020 19:19
@ethanfrogers
Copy link
Contributor

@parondeau is correct. Applications names can have - in them now. I'm not sure how it behaves when using any of the VM based providers as it would conflict with Frigga but the Kubernetes V2 provider certainly supports it. Thanks for the contribution!

@ethanfrogers ethanfrogers merged commit e857b66 into armory-io:master Jan 14, 2020
lifeofguenter pushed a commit to tidal-engineering/terraform-provider-spinnaker that referenced this pull request Sep 18, 2020
Squashed commit of the following:
f232f95 
commit 4b31b7262be8dd57994ff936662dbebd03073ae2
Author: Gunter Grodotzki <gunter.grodotzki@tidal.com>
Date:   Fri Sep 18 14:01:14 2020 +0200

    Squashed commit of the following:

    commit 5634bb9
    Author: Gunter Grodotzki <gunter.grodotzki@tidal.com>
    Date:   Fri Sep 18 14:00:15 2020 +0200

        Squashed commit of the following:

        commit 35ebf55
        Author: Gunter Grodotzki <gunter.grodotzki@tidal.com>
        Date:   Fri Sep 18 13:59:25 2020 +0200

            bumb sdk

commit 9189ab3
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 23:49:49 2020 +0200

    Publish on v* tag

commit 7a9ed84
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 23:26:12 2020 +0200

    goreleaser changes

commit 3388675
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 22:03:18 2020 +0200

    changelog

commit 2392c9c
Merge: e857b66 4f707e3
Author: Bishwa Shrestha <bishwa.shrestha@gmail.com>
Date:   Mon Sep 14 21:55:52 2020 +0200

    Merge pull request #1 from tidal-engineering/github_workflows

    Goreleaser + GH workflows

commit 4f707e3
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 21:53:17 2020 +0200

    Separate workflows for branches and tags

commit de1f6e9
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 21:28:42 2020 +0200

    terraform registry scaffolding

commit bbe2fbb
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 16:34:10 2020 +0200

    PR builds

commit 3c50f42
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 16:12:18 2020 +0200

    Goreleaser + GH workflows

commit e857b66
Author: Paul Rondeau <paulrondeau07@gmail.com>
Date:   Tue Jan 14 06:04:11 2020 -0800

    added dash to allowable application name regex (armory-io#41)

commit d503979
Author: Damian Myerscough <dmyerscough@users.noreply.github.com>
Date:   Thu Nov 28 14:40:59 2019 -0800

    Fix Terraform syntax (armory-io#34)

commit 2559f91
Author: Damian Myerscough <dmyerscough@users.noreply.github.com>
Date:   Thu Nov 28 14:40:08 2019 -0800

    Fix Apache Thrift location (armory-io#33)

commit 73e60f5
Author: Bishwa Shrestha <bishwa.shrestha@gmail.com>
Date:   Thu Nov 28 23:37:44 2019 +0100

    Add validation for spinnaker application name (armory-io#37)
lifeofguenter pushed a commit to tidal-engineering/terraform-provider-spinnaker that referenced this pull request Sep 18, 2020
Squashed commit of the following:
d478898 
commit 4b31b7262be8dd57994ff936662dbebd03073ae2
Author: Gunter Grodotzki <gunter.grodotzki@tidal.com>
Date:   Fri Sep 18 14:01:14 2020 +0200

    Squashed commit of the following:

    commit 5634bb9
    Author: Gunter Grodotzki <gunter.grodotzki@tidal.com>
    Date:   Fri Sep 18 14:00:15 2020 +0200

        Squashed commit of the following:

        commit 35ebf55
        Author: Gunter Grodotzki <gunter.grodotzki@tidal.com>
        Date:   Fri Sep 18 13:59:25 2020 +0200

            bumb sdk

commit 9189ab3
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 23:49:49 2020 +0200

    Publish on v* tag

commit 7a9ed84
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 23:26:12 2020 +0200

    goreleaser changes

commit 3388675
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 22:03:18 2020 +0200

    changelog

commit 2392c9c
Merge: e857b66 4f707e3
Author: Bishwa Shrestha <bishwa.shrestha@gmail.com>
Date:   Mon Sep 14 21:55:52 2020 +0200

    Merge pull request #1 from tidal-engineering/github_workflows

    Goreleaser + GH workflows

commit 4f707e3
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 21:53:17 2020 +0200

    Separate workflows for branches and tags

commit de1f6e9
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 21:28:42 2020 +0200

    terraform registry scaffolding

commit bbe2fbb
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 16:34:10 2020 +0200

    PR builds

commit 3c50f42
Author: Bishwa Shrestha <bishwa.shrestha@tidal.com>
Date:   Mon Sep 14 16:12:18 2020 +0200

    Goreleaser + GH workflows

commit e857b66
Author: Paul Rondeau <paulrondeau07@gmail.com>
Date:   Tue Jan 14 06:04:11 2020 -0800

    added dash to allowable application name regex (armory-io#41)

commit d503979
Author: Damian Myerscough <dmyerscough@users.noreply.github.com>
Date:   Thu Nov 28 14:40:59 2019 -0800

    Fix Terraform syntax (armory-io#34)

commit 2559f91
Author: Damian Myerscough <dmyerscough@users.noreply.github.com>
Date:   Thu Nov 28 14:40:08 2019 -0800

    Fix Apache Thrift location (armory-io#33)

commit 73e60f5
Author: Bishwa Shrestha <bishwa.shrestha@gmail.com>
Date:   Thu Nov 28 23:37:44 2019 +0100

    Add validation for spinnaker application name (armory-io#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrogers ethanfrogers ethanfrogers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parondeau @dotdotdotpaul @ethanfrogers