Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: after sending a string of DTMF using the * key, next keypress is eaten. #138

Closed
prokrypt opened this issue Jun 16, 2024 · 10 comments
Closed
Labels
bug Something isn't working

Comments

@prokrypt
Copy link

Affects all keys except for PTT and channel buttons, both short press and long press.

@prokrypt prokrypt changed the title After sending a string of DTMF using the * key, next keypress is eaten. bug: after sending a string of DTMF using the * key, next keypress is eaten. Jun 16, 2024
@armel
Copy link
Owner

armel commented Jun 16, 2024

Sorry, I don't understand where is the problem.

@prokrypt
Copy link
Author

prokrypt commented Jun 16, 2024

Ah, while trying to make a video, I discovered the problem is a little more complex...

  • Turn on radio
  • Press "*"
  • Input some DTMF
  • Press PTT to send
  • Press "*"
  • Press PTT to send
  • Next keypress (other than PTT or up/down) is ignored.

It doesn't ignore the subsequent keypress the first time after boot, but will do so every time after.

@prokrypt
Copy link
Author

demo.mp4

@armel armel added the bug Something isn't working label Jun 16, 2024
@armel
Copy link
Owner

armel commented Jun 16, 2024

Ok.
I have no idea where this is coming from.
I tag the issue as a bug, if someone wants to take care of fixing it.

Armel F4HWN.

@prokrypt
Copy link
Author

demo2.mp4

getting closer to figuring it out... maybe

@f1ixx
Copy link

f1ixx commented Jun 18, 2024

Hello

I read and try to understand. Waw, high level for me.
But after many UART_printf to read data, may flash, i make this :
in file app/app.c :
line 1872 :

if (!bKeyPressed) {
	bFlag           = true;
	gPttWasReleased = false;
	}

change to

if (!bKeyPressed) {
	//bFlag           = true;
	gPttWasReleased = false;
	}

I make small test and it sames to work but but but as usual, fixes
a bug adds new bug(s).

If more harm than good, return to the origin and/or report the new problem(s)

Forget idea. Thank's

73's
Boris

@prokrypt
Copy link
Author

prokrypt commented Jun 18, 2024

@f1ixx getting very close! That does indeed fix the problem, but it is probably the wrong place to change code as it introduces a new bug:

  • press * twice. oops!
  • press * once then long press * again. hmmmm... interesting.

@prokrypt
Copy link
Author

prokrypt commented Jun 18, 2024

I tried to have a go at it...
comment out line 681 (gPttWasReleased = true;) in main.c:

gPttWasReleased = true;

It seems to work fine so far. Hmm.

@prokrypt
Copy link
Author

I've been testing this for the past few days, still no bugs! 🎉

@armel
Copy link
Owner

armel commented Jun 26, 2024

Ok thank you 👍🏼 This issue will be fiexed in the next version.

@armel armel closed this as completed Jun 26, 2024
armel added a commit that referenced this issue Jun 26, 2024
@armel armel mentioned this issue Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants