feat: first version of new workflows #2214
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2214 +/- ##
===========================================
- Coverage 58.78% 47.30% -11.48%
===========================================
Files 225 263 +38
Lines 28475 37263 +8788
===========================================
+ Hits 16738 17626 +888
- Misses 10442 18241 +7799
- Partials 1295 1396 +101
Flags with carried forward coverage won't be shown. Click here to find out more. see 38 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
|
||
| - name: Setup dependencies | ||
| shell: bash | ||
| run: make download |
There was a problem hiding this comment.
Do this instead https://github.com/armadaproject/armada/blob/master/makefile#L576
go run github.com/magefile/mage@v1.14.0 BootstrapTools
go mod download
go mod tidy
There was a problem hiding this comment.
So we can start removing the need for the makefile.
| @@ -0,0 +1,204 @@ | |||
| name: Code Build and Tests | |||
There was a problem hiding this comment.
This means unit and integration tests will run sequentially? Can we run them in paralle?
There was a problem hiding this comment.
Jobs in the same workflow run in parallel by default.
Fixes #
Special notes for your reviewer:
┆Issue is synchronized with this Jira Task by Unito