feat: add option to switch line endings to LF #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f6ad31 to
dfd4c6d
Compare
dfd4c6d to
dc0d8ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #2036
The original problem is that some laser firmwares allow LF line endings ("\n") but not CRLF ("\r\n"). The line endings work correctly in the paid software, LightBurn. In my case, I have the Creality Laser Engraver CR Falcon SE which shows the firmware as Grbl 1.3a.
This PR adds a checkbox in the advanced options to use LF line endings on the exported gcode file. The checkbox is unchecked by default since most users probably don't need this.