Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Use Rich for j2lint outputs and logs #55

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Jan 11, 2023

Fixes #13

Requires #52 to be merged first

Open for discussions for the current outputs

List rules

Screenshot 2023-01-11 at 22 28 29

No problem

Screenshot 2023-01-11 at 22 29 41

Errors

Screenshot 2023-01-11 at 22 28 55

@gmuloc gmuloc force-pushed the rich-logging branch 4 times, most recently from d470c58 to 450353e Compare January 18, 2023 12:20
@ryanmerolle
Copy link

anything blocking this PR?

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 9184e9b into aristanetworks:devel Apr 12, 2023
@gmuloc
Copy link
Collaborator Author

gmuloc commented Apr 12, 2023

Thanks for the nudge @ryanmerolle - can you give us feedback on the current version in devel?

@ryanmerolle
Copy link

LGTM. I tested a bunch scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rich for better output
4 participants